Removed unused __str__() methods in tests models.

[atombrella]

Maybe there are more of such things in the test suite. Perhaps we can leave this PR to look for more, instead of merging immediately.

[adamchainz]

How did you find these? Ran the test suite with coverage? I see our Jenkins coverage report doesn't cover the tests.

[atombrella]

How did you find these? Ran the test suite with coverage? I see our Jenkins coverage report doesn't cover the tests.

It was a bit by coincident: I opened a models file in PyCharm, and the self.name was highlighted. Then I thought that they're probably more. The content of some of those models file has not been touched for ~8-12 years. I haven't thought of coverage of the tests.

[hramezani]

@atombrella I found some of them. it is possible to push to your branch?

[felixxm]

I pushed few more.

[felixxm]

... and 7 more. 457 __str__() methods left.

[atombrella]

@atombrella I found some of them. it is possible to push to your branch?

@hramezani Thank you, please just list them here. I think that's a better approach. @felixxm Please remember to add yourself in Co-Authored-By. Thank you.

It seems that self.name caught quite a few of them.

Do you use something like grep -r -A 2 -B 10 __str__ --include="*.py" tests/ to check?

[hramezani]

Do you use something like grep -r -A 2 -B 10 str --include="*.py" tests/ to check?

Yes, I do.

Here is the diff file. It will remove 25 of them.

[felixxm]

I used find -name models.py | xargs grep 'def __str__' .

[felixxm]

I added few more. I think it's a good start that it's worth to merge. We removed 50 methods.