Refs #27852 -- Fixed object deletion to show all restricted related objects rather than just the first one. #12376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramezani
force-pushed
the
ticket_27852
branch
from
098ba95
to
0f179bd
Compare
felixxm
reviewed
Jan 28, 2020
| @@ -175,7 +186,7 @@ def test_restrict_path_cascade_indirect(self): | |||
| a.restrict.save() | |||
| msg = ( | |||
| "Cannot delete some instances of model 'R' because they are " | |||
| "referenced through a restricted foreign key: 'A.restrict'." | |||
| "referenced through restricted foreign keys: 'A.restrict'." | |||
There was a problem hiding this comment.
Previous message was incorrect, IMO. We tried to delete a P instance so we should get a message about P even if restricted foreign keys are from other models (R in this case). Restricted foreign keys can be reached from a long and complicated paths so I don't think we can do much to improve this message.
|
@hramezani Thanks 👍 I pushed minor edits. |
…bjects rather than just the first one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the comment about restricted objects on ticket 27852.