Move technical_500 template paths to class-level variables #12393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
reviewed
Jan 31, 2020
This allows effortless replacement of the debugging templates without having to copy-paste the `get_traceback_html` and `get_traceback_text` functions into a deriving class.
|
Tests should be added to demonstrate overriding these class variables. Can you also add a ticket to Django Trac? |
|
@akx All new features require an accepted ticket. Can you create a new ticket for this feature? |
|
Closing due to lack of follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows effortless replacement of the debugging templates without having to copy-paste the
get_traceback_htmlandget_traceback_textfunctions into a deriving class.