Fixed #20995 -- Added support for iterables of template names to {% include %} template tag. #12407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
reviewed
Feb 3, 2020
adamchainz
reviewed
Feb 12, 2020
|
Is there more changes left ? |
|
Not from me but the fellows might spot something. Make sure the ticket on Trac is not marked as needing improvement so that they see it. |
|
Ok, I have unset it. |
kezabelle
reviewed
Feb 14, 2020
felixxm
changed the title
felixxm
changed the title
felixxm
reviewed
Feb 17, 2020
There was a problem hiding this comment.
@keshav2212 Thanks for this patch 👍 I pushed edits to docs, made tests use subTest(), and added test and fix for None.
felixxm
force-pushed
the
ticket_20995
branch
2 times, most recently
from
3b03e0c
to
143d87a
Compare
|
@felixxm Thank you for review. |
…nclude %} template tag. Thanks Adam Johnson for the review.
felixxm
force-pushed
the
ticket_20995
branch
from
143d87a
to
f37d548
Compare
|
Thanks @adamchainz , @kezabelle and @felixxm For helping me in my first issue. |
|
@keshav2212 Welcome aboard ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.