Fixed #26552 -- Deferred constraint checks when reloading the database with data for tests. #12453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijskooijman
force-pushed
the
fix-26552
branch
from
dc3b1bc
to
22dfd2c
Compare
matthijskooijman
force-pushed
the
fix-26552
branch
from
22dfd2c
to
7842b1f
Compare
|
Just found a problem with the testcase (I wrongly assumed the Book model was unused and changed it, and somehow this did not show up in my local testruns). Anyway, I now just use the existing Book and Author models as-is (with a foreignkey to "name" rather than the pk), which works fine for this test (if anyone prefers, I can also add separate models as well). |
…e with data for tests. deserialize_db_from_string() loads the full serialized database contents, which might contain forward references and cycles. That caused IntegrityError because constraints were checked immediately. Now, it loads data in a transaction with constraint checks deferred until the end of the transaction.
felixxm
changed the title
felixxm
reviewed
Feb 14, 2020
There was a problem hiding this comment.
@matthijskooijman Thanks 👍 I simplified tests and pushed minor edits.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of PR #12166, just fixing issue-26552.