Fixed #31051 -- Allowed dumpdata to handle circular references in natural keys. #12458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijskooijman
force-pushed
the
fix-31051
branch
from
0de0cc7
to
68d98d2
Compare
matthijskooijman
changed the title
felixxm
reviewed
Apr 2, 2020
There was a problem hiding this comment.
@matthijskooijman Thanks 👍 Sorry for a delay but I'm still trying to split these changes into related/unrelated bits.
|
Rebased. |
felixxm
reviewed
Apr 3, 2020
|
I tried to move all tests that work without this patch to a separate PR #12680. |
|
Rebased on top of #12680. |
felixxm
changed the title
…ural keys. Since #26291 forward references in natural keys are properly handled by loaddata, so sorting depenencies in dumpdata doesn't need to break on cycles. This patch allows circular references in natural keys by breaking sort_depenencies() on loops.
…ign keys are not used. There is no need to sort dependencies when natural foreign keys are not used.
|
@matthijskooijman Thanks again 👍 I pushed minor edits and reorganized commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly cleaned up version of #12166, fixing just ticket-31051.