Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #31341 -- Doc'd minimal gettext version with ES6 template strings support. #12528

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

claudep
Copy link
Member

@claudep claudep commented Mar 5, 2020

No description provided.

@felixxm felixxm self-assigned this Mar 5, 2020
@cedeber
Copy link

cedeber commented Mar 5, 2020

Hi. gettext 0.20.x seems still buggy with templates strings. Looks like the 0.21 should fix that. See gettext bug report. Thanks.

@claudep
Copy link
Member Author

claudep commented Mar 5, 2020

Should we mention the future gettext 0.21 now and update the docs when it is released? @felixxm, what wording would you suggest?

@claudep
Copy link
Member Author

claudep commented Mar 5, 2020

Or maybe just wait for the next gettext release before updating the documentation…

@felixxm
Copy link
Member

felixxm commented Mar 5, 2020

@claudep I'm not sure, we can wait few years for gettext 0.21 🤔 #56678 is a bug in a new feature so they can release 0.20.2 instead of 0.21. IMO the current wording is fine, because gettext added official support for JavaScript template literals in 0.20, bugs in their implementation shouldn't impact our docs. We can adjust it later after the next gettext release.

@cedeber
Copy link

cedeber commented Mar 5, 2020

In the gettext log 0.21 is from December 2019, but not yet released. No ideas why.

@felixxm
Copy link
Member

felixxm commented Mar 5, 2020

@cedeber Thanks for sharing this source. In that case I think we can mention unreleased version of gettext, e.g.:

JavaScript template strings need ``gettext`` 0.21+.

@felixxm felixxm changed the title Fixed #31341 -- Documented minimal gettext for ES6 template strings support. Fixed #31341 -- Doc'd minimal gettext version with ES6 template strings support. Mar 5, 2020
@felixxm felixxm merged commit 2f53d32 into django:master Mar 5, 2020
@claudep claudep deleted the 31341 branch March 5, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants