Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc'd return values of as_sql() for Func and query expressions. #12529

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Doc'd return values of as_sql() for Func and query expressions. #12529

merged 1 commit into from
Mar 6, 2020

Conversation

adamchainz
Copy link
Sponsor Member

Mostly to make it clear that params may be a list or tuple.

@adamchainz adamchainz force-pushed the documented_as_sql_return_types branch 2 times, most recently from 0590035 to 486aa5d Compare March 5, 2020 09:15
@felixxm felixxm changed the title Documented return types of as_sql methods Doc'd return values of as_sql() for Func and query expressions. Mar 6, 2020
@adamchainz adamchainz force-pushed the documented_as_sql_return_types branch from 486aa5d to e42d38e Compare March 6, 2020 11:43
@felixxm felixxm removed the request for review from charettes March 6, 2020 11:52
@felixxm felixxm merged commit 8c1b073 into django:master Mar 6, 2020
@felixxm
Copy link
Member

felixxm commented Mar 6, 2020

@adamchainz Thanks 👍

@adamchainz adamchainz deleted the documented_as_sql_return_types branch March 25, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adamchainz @felixxm @carltongibson