Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #27865 -- Adjusted docs example to avoid confusion with private BaseManager. #12543

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

radwon
Copy link
Contributor

@radwon radwon commented Mar 8, 2020

Rename BaseManager to CustomManager in docs to avoid any confusion with django.db.models.manager.BaseManager and use MyManager as the Manager for MyModel.

Fixes https://code.djangoproject.com/ticket/27865

Rename BaseManager to CustomManager in docs to avoid any confusion with django.db.models.manager.BaseManager and use MyManager as the Manager for MyModel.

Fixes https://code.djangoproject.com/ticket/27865
@carltongibson carltongibson changed the title Fixed #27865 -- Rename BaseManager to CustomManager in docs. Fixed #27865 -- Adjusted docs example to avoid confusion with private BaseManager. Mar 10, 2020
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, yes thanks. I think this will save someone somewhere a cycle. 👍

@carltongibson carltongibson merged commit a2f5542 into django:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants