Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #29299 -- Add type annotations to gettext. #12544

Closed
wants to merge 1 commit into from
Closed

Refs #29299 -- Add type annotations to gettext. #12544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion django/utils/translation/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def ugettext_noop(message):
return gettext_noop(message)


def gettext(message):
def gettext(message: str) -> str:
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is accurate. The underlying gettext() function for when translations are active doesn't seem to make guarantees about type, and uses mark_safe in the case of messages that are already SafeData:

django/django/utils/translation/trans_real.py

Line 275 in eb77e80

def gettext(message):

return _trans.gettext(message)


Expand Down