Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed random auth_tests.test_tokens.TokenGeneratorTest.test_timeout failures. #12560

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Mar 12, 2020

Random failures depended on the current timestamp.

Copy link
Contributor

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just noted one improvement inline. Thanks for the quick response! :-)

tests/auth_tests/test_tokens.py Outdated Show resolved Hide resolved
…ailures.

Random failures depended on the current timestamp.

Thanks Matthijs Kooijman for the review.
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@felixxm felixxm merged commit 8725d04 into django:master Mar 12, 2020
@felixxm felixxm deleted the random-test-timeout branch March 12, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants