Fixed #31371 -- Increased User.first_name max_length to 150 characters. #12581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 30 character first name limit has been reported in another open source project I maintain (which uses Django), Ansible AWX: ansible/awx#6281 This PR updates the field to match the (expanded) length of the last name field. |
ryanpetrello
force-pushed
the
ticket_31371
branch
2 times, most recently
from
72ff018
to
2211263
Compare
hramezani
suggested changes
Mar 17, 2020
There was a problem hiding this comment.
Thanks @ryanpetrello.
Please change the migration file name:
0012_alter_user_last_name_max_length.py -> 0012_alter_user_first_name_max_length.py
Please change the user model first_name field doc. Please add a .. versionchanged:: as well.
ryanpetrello
force-pushed
the
ticket_31371
branch
from
2211263
to
9daf235
Compare
|
Thanks @hramezani; feedback addressed. |
felixxm
changed the title
felixxm
changed the title
felixxm
changed the title
|
@ryanpetrello Thanks 👍 I added some docs. Welcome aboard ⛵ |
allynt
added a commit
to astrosat/django-astrosat-users
that referenced
this pull request
Aug 13, 2020
Changed the way DjangoModelFactory is imported as per FactoryBoy/factory_boy@43f557d Also updated user migrations as per django/django#12581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the max_length of first_name in django.contrib.auth to 150 characters to facilitate longer first names.
Fixes ticket-31371