Refs #28215 -- Marked credentials as a sensitive variables.

[hramezani]

Continue #10921
Addressed reviewer comments.
I've created setUp function in test and defined password there to don't use a password like 'secret' + 'test'.
Also, I think there is no need for third test, So, I removed it.

[collinanderson]

@hramezani Thank you for picking this up!

[hramezani]

@hramezani Thank you for picking this up!

@collinanderson You are welcome.
I just completed it. The main effort was yours.
Thank you for the initial patch.

[carltongibson]

Hi @hramezani (hi @collinanderson 👋 ) This looks great, thanks!

Two questions:

• Can we call this Fixed ... — there's not much else we could do here right?
• Should ModelBackend.authenticate() be marked with sensitive_variables as part of this? (I'm not really seeing the benefit of marking the test TypeErrorBackend otherwise...

Thanks.

[hramezani]

Hi @carltongibson

Can we call this Fixed ... — there's not much else we could do here right?

I think this patch addresses just the case that we have an error during the login.

Should ModelBackend.authenticate() be marked with sensitive_variables as part of this?

I don't think so. Why should we mark ModelBackend.authenticate() as well?

I'm not really seeing the benefit of marking the test TypeErrorBackend otherwise...

We are going to test sensitive variables when we have an error in login. So, I think the TypeErrorBackend does it for us and we can use it.

I rebased the patch and added @collinanderson as Co-authored because he was the initiator of the patch and I just completed it.

[carltongibson]

OK, super. Thanks both.