Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #31351 -- Made partial constraints tests use required_db_features. #12735

Merged
merged 1 commit into from Apr 17, 2020
Merged

Refs #31351 -- Made partial constraints tests use required_db_features. #12735

merged 1 commit into from Apr 17, 2020

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Apr 17, 2020 •
edited

This will notably silence the warnings issued when running the test suite on MySQL and MariaDB:

constraints.UniqueConstraintProduct: (models.W036) MariaDB does not support unique constraints with conditions.
    HINT: A constraint won't be created. Silence this warning if you don't care about it.

@felixxm
Refs #31351 -- Made partial constraints tests use required_db_features.
8904427 
This will notably silence the warnings issued when running the test
suite on MySQL and MariaDB.
@felixxm felixxm force-pushed the mysql-mariadb-partial-unique branch from d1e088e to 8904427 Compare April 17, 2020 05:15
@felixxm
Copy link
Member Author

felixxm commented Apr 17, 2020

@charettes Thanks for the review 👍

@felixxm felixxm merged commit 4c98860 into django:master Apr 17, 2020
@felixxm felixxm deleted the mysql-mariadb-partial-unique branch April 17, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charettes charettes charettes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@felixxm @charettes