Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #30372 -- Stopped watching built-in Django translation files by auto-reloader. #12750

Merged
merged 1 commit into from May 4, 2020
Merged

Conversation

orf
Copy link
Sponsor Contributor

@orf orf commented Apr 18, 2020

@orf orf changed the title WIP: Ref #30372 - Skip watching built-in Django translation files for changes Refs #30372 - Skip watching built-in Django translation files for changes Apr 27, 2020
Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

@orf
Copy link
Sponsor Contributor Author

orf commented May 2, 2020

I was hoping to get more feedback about if it solved the reporters issue or not, but he doesn’t seem to have it anymore.

I remember someone reporting something similar last year, and disabling i18n reduced his CPU load considerably. So, I think we should merge this.

@claudep
Copy link
Member

claudep commented May 2, 2020

Monitoring django translation files has very little use, so if it can improve some performance, I agree we should do it.

@felixxm felixxm changed the title Refs #30372 - Skip watching built-in Django translation files for changes Refs #30372 -- Stopped watching built-in Django translation files by auto-reloader. May 4, 2020
@felixxm
Copy link
Member

felixxm commented May 4, 2020

@orf Thanks 👍 I added small release notes.

@felixxm felixxm merged commit c00bc27 into django:master May 4, 2020
@orf orf deleted the 30372-speedups branch May 4, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants