Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #31517 -- Fixed HashedFilesMixin.hashed_name() if hash of the file is None. #12803

Merged
merged 1 commit into from Apr 28, 2020
Merged

Fixed #31517 -- Fixed HashedFilesMixin.hashed_name() if hash of the file is None. #12803

merged 1 commit into from Apr 28, 2020

Conversation

campenr
Copy link
Contributor

@campenr campenr commented Apr 26, 2020

… if file_hash returns None

felixxm
felixxm reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@campenr Thanks for this patch 👍

docs/ref/contrib/staticfiles.txt Outdated Show resolved Hide resolved
tests/staticfiles_tests/test_storage.py Outdated Show resolved Hide resolved
django/contrib/staticfiles/storage.py Outdated Show resolved Hide resolved
@felixxm felixxm changed the title Fixed #31517 -- ManifestFilesMixin hashed file name remains unchanged… Fixed #31517 -- Fixed HashedFilesMixin.hashed_name() if hash of the file is None. Apr 28, 2020
@felixxm
Copy link
Member

felixxm commented Apr 28, 2020

@campenr Thanks 👍 Welcome aboard ⛵

I simplified tests.

@felixxm felixxm merged commit 67b334f into django:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@campenr @felixxm