Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #30400 -- Improved typography of user facing strings in admin changelist. #12804

Merged
merged 2 commits into from Apr 29, 2020
Merged

Refs #30400 -- Improved typography of user facing strings in admin changelist. #12804

merged 2 commits into from Apr 29, 2020

Conversation

jdufresne
Copy link
Member

No description provided.

@jdufresne
Copy link
Member Author

buildbot, test on selenium.

ngnpope
ngnpope approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Thanks for improving the test coverage too.

@felixxm felixxm changed the title Refs #30400 -- Improved typography of user facing strings in actions.js. Refs #30400 -- Improved typography of user facing strings in admin changelist. Apr 29, 2020
@felixxm
Copy link
Member

felixxm commented Apr 29, 2020

@jdufresne Thanks 👍 I moved new tests to a separate commit.

@felixxm felixxm merged commit 0dafada into django:master Apr 29, 2020
@jdufresne jdufresne deleted the actions-typography branch May 2, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngnpope ngnpope ngnpope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jdufresne @felixxm @ngnpope