Fixed the centering of the "Log in" button on admin login page. #12847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2020
Previously, the button's container had a padding of 9.4em which was approximately center but not precisely. Now, the container uses 'align: text-center' to let the browser center the button.
|
buildbot, test on selenium. |
|
Hey @jdufresne. I rebased this after #12846. Can you confirm it's how you'd expect it? Ta. |
carltongibson
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Looks good. Thanks! Just wait for Selenium and @jdufresne... 👍
|
👍 Rebase looks good to me. Thanks for handling that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the button's container had a padding of 9.4em which was
approximately center but not precisely. Now, the container uses 'align:
text-center' to let the browser center the button.