Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 31597 - New "Clear all filters" shown always in raw_id_fields popup #12924

Closed
wants to merge 2 commits into from

Conversation

frnhr
Copy link
Contributor

@frnhr frnhr commented May 16, 2020

Ticket https://code.djangoproject.com/ticket/31597

raw_id_fields popup

The new feature (PR #12351 ) has 2 issues with raw_id_fields:

  1. the new link is shown when _popup=1 is present in the URL query, regardless of any actual filters
  2. clicking on the link will preserve _popup query param (which is correct) but it will remove _to_field param, which should probably also be preserved

@frnhr frnhr marked this pull request as ready for review May 16, 2020 21:53
@frnhr frnhr changed the title Ticket 31597 Ticket 31597 - New "Clear all filters" shown always in raw_id_fields popup May 16, 2020
@frnhr
Copy link
Contributor Author

frnhr commented May 18, 2020

Potentially resolved by PR #12931

@felixxm
Copy link
Member

felixxm commented May 19, 2020

Superseded by #12934.

@felixxm felixxm closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants