Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #6933 -- Added support for searching against quoted phrases in ModelAdmin.search_fields. #12979

Merged
merged 1 commit into from Jun 18, 2020

Conversation

alixleger
Copy link
Contributor

With phrases surrounded with double quotes

@alixleger
Copy link
Contributor Author

Is it possible to add this admin search improvement in the 3.1 ?

@claudep
Copy link
Member

claudep commented May 27, 2020

Unfortunately not, as the 3.1 branch is now feature frozen (alpha stage).

@alixleger
Copy link
Contributor Author

Alright, thanks

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alixleger Thanks 👍

django/contrib/admin/options.py Outdated Show resolved Hide resolved
tests/admin_views/tests.py Outdated Show resolved Hide resolved
@alixleger
Copy link
Contributor Author

@alixleger Thanks +1

Thanks for the review, it's updated !

@felixxm
Copy link
Member

felixxm commented Jun 18, 2020

@alixleger Thanks 👍 Welcome aboard ⛵

I added tests for single quotes and used subTest().

@felixxm felixxm changed the title Fixed #6933 -- Added a new feature to allow search by phrases Fixed #6933 -- Added support for searching against quoted phrases in ModelAdmin.search_fields. Jun 18, 2020
@felixxm felixxm self-assigned this Jun 18, 2020
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the single comment on the docs. Looks super.

ticket-6933 my word! 😀

docs/ref/contrib/admin/index.txt Outdated Show resolved Hide resolved
@felixxm felixxm merged commit 26a4135 into django:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants