New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #31713 -- Added SpatialReference support to GDALRaster.transform(). #13082
Conversation
I would be for keeping support for passing an integer SRID. Or do you have a specific reason to prevent it? |
My reasoning behind it was that one could pass a SpatialReference object which takes a multitude of inputs anyways. That way the function signature would be clear while keeping a high degree of flexibility. However, there’s even less hassle to keep the int input when thinking of depreciation warnings anyways. So I’m good with either way. |
Yes, I'd rather have a similar behavior as: |
Have a look now. I skipped to support CoordTransform objects. I am not familiar with the cAPI and don't know how I would need to massage the pointer to obtain the target SRID from the target SpatialReference system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already in good shape in my opinion, thanks!
Let me know if there's anything else to do here :) |
Maybe rebase the patch, then wait for a finer review by one of the Django fellows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rico-ci Thanks for this patch 👍
@rico-ci Thanks 👍 Welcome aboard ⛵ I used |
Cheers @felixxm! Was a good first one to get started here. |
Deprecated integer SRID as function argument in
django.contrib.gis.gdal.GDALRaster.transform
in favor of directly passing a SpatialReference item to the transform (django.contrib.gis.gdal.SpatialReference
).Providing patch with updated documentation, release notes, and internal deprecation log.
This is my first PR so please point out anything that can be improved!
Very much appreciated.