Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #29403 -- Made PyLibMCCache backend handle TooBig exception from pylibmc. #13136

Closed
wants to merge 1 commit into from

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jul 2, 2020

Ticket: https://code.djangoproject.com/ticket/29403
Continue to #9811

I removed the self._cache.delete(key) and it seems we don't need it. if I add a test in PyLibMCCacheTests like:

    def test_large_value(self):
        cache.set('key', 'a')
        large_value = 'a' * (1024 * 1024)
        cache.set('key', large_value)
        value = cache.get('key')
        self.assertIsNone(value)

It will be passed successfully. Do we need to add this test?

@felixxm
Copy link
Member

felixxm commented Jul 3, 2020

Thanks for your efforts! However I'm going to close this per comment.

@felixxm felixxm closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants