Fixed #20693 -- Add timezone support to built-in time filter. #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Ticket 20693: Add timezone support to built-in time template filter | ||
| 'time01': (r'{{ dt|time:"P:e:O:T:Z" }}', {'dt': datetime(2013, 7, 2, 4, 0, tzinfo=FixedOffset(30))}, '4 a.m.:+0030:+0030:+0030:1800'), | ||
| 'time02': (r'{{ dt|time:"P:e:O:T:Z" }}', {'dt': datetime(2013, 7, 2)}, 'midnight::-0500:CDT:-18000'), | ||
| 'time03': (r'{{ t|time:"P:e:O:T:Z" }}', {'t': time(4, 0, tzinfo=FixedOffset(30))}, '4 a.m.::::'), |
There was a problem hiding this comment.
Is datetime.date covered elsewhere?
There was a problem hiding this comment.
I've added a test for datetime.date. The results are not any different than for any other object that doesn't contain time information, but it is better to handle that case explicitly.
I also realized that the time02 test contained success criteria that was not portable. I have fixed that.
|
Sorry for the late comment. It is my belief that after this change it would be ready for checkin (and I'll mark it as such). |
Modified django.utils.dateformat module, moving __init__() method and timezone-related format methods from DateFormat class to TimeFormat base class. Modified timezone-related format methods to return an empty string when timezone is inappropriate for input value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified django.utils.dateformat module, moving init() method and
timezone-related format methods from DateFormat class to TimeFormat
base class. Modified timezone-related format methods to return an
empty string when timezone is inappropriate for input value.