Changed "Don't overuse count() or exists()" example to Python #13294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does seem nice but instead of removing the existing snippet, how about just adding this one along with that? |
vsasvipul0605
approved these changes
Aug 13, 2020
|
I think keeping both versions is just bloat. Anyone who understands the Python version and how templates work should be able to understand how the problem can appear in templates too. |
adamchainz
force-pushed
the
improve_overuse_documentation
branch
from
ae2dd32
to
c338fe1
Compare
felixxm
force-pushed
the
improve_overuse_documentation
branch
from
c338fe1
to
8a642b8
Compare
felixxm
reviewed
Jan 27, 2021
docs/topics/db/optimization.txt
Outdated
| @@ -261,46 +261,38 @@ Don't overuse ``count()`` and ``exists()`` | |||
| If you are going to need other data from the QuerySet, evaluate it immediately. | |||
|
|
|||
| For example, assuming an Email model that has a ``body`` attribute and a | |||
There was a problem hiding this comment.
Suggested change
| For example, assuming an Email model that has a ``body`` attribute and a | |
| For example, assuming an Email model that has a ``subject`` attribute and a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Django developers don't use templates these days, instead working on API's. The ORM is the common denominator, and I think the plain Python makse the example a littl clearer.