Use UnsafeLoader for fixtures loading in YAML #13320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing per ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://code.djangoproject.com/ticket/31896#ticket
Currently, Django uses PyYAML's SafeLoader to load fixtures which prevent to use some advance utils like
!!python/object/apply. For example, to create dates related to the current date for example, and not static dates that you have to update over time so that they aren't too old.Anyway, there could be many reasons why a developer would want to use such an util in features. And I believe it should be safe to use UnsafeLoader for fixtures since this is certainly a data that developers create themselves.