Fixed #31766 -- Made GDALRaster.transform() return a clone for the same SRID and driver. #13365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonip
force-pushed
the
master
branch
3 times, most recently
from
a778f6b
to
23e5900
Compare
hramezani
reviewed
Aug 30, 2020
bartonip
force-pushed
the
master
branch
8 times, most recently
from
5aee02a
to
25be51b
Compare
bartonip
force-pushed
the
master
branch
10 times, most recently
from
7cac0b5
to
03cc033
Compare
felixxm
reviewed
Aug 31, 2020
|
@felixxm refer to the current build, its because it doesnt work |
|
@bartonip Thanks for demonstration. |
|
@felixxm reverted and ready for merge |
|
@yellowcap Can you take a look? Thanks. |
felixxm
changed the title
felixxm
force-pushed
the
master
branch
2 times, most recently
from
4484246
to
a758017
Compare
yellowcap
suggested changes
Sep 8, 2020
|
@yellowcap Thanks for the review 👍 I pushed edits and extra tests. |
felixxm
changed the title
|
Daniel, Can you take a look at my updates? Thanks 🌟 |
…me SRID and driver. Thanks Daniel Wiesmann for the review.
|
Thanks both 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a clone method using ds_copy to clone GDALRaster objects.
Added conditional to simply return a clone of GDALRaster if SRID matches with transform srs argument.