Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #31982 -- Made HttpResponse.set_cookie() cast max_age argument to an integer. #13386

Merged
merged 1 commit into from Sep 5, 2020
Merged

Fixed #31982 -- Made HttpResponse.set_cookie() cast max_age argument to an integer. #13386

merged 1 commit into from Sep 5, 2020

Conversation

hramezani
Copy link
Member

@felixxm felixxm changed the title Fixed #31982 -- Convert max_age to an int in HttpResponseBase.set_cookie(). Fixed #31982 -- Made HttpResponse.set_cookie() cast max_age argument to an integer. Sep 5, 2020
@felixxm
Copy link
Member

felixxm commented Sep 5, 2020

@hramezani Thanks 👍

I pushed minor edits to tests.

@felixxm felixxm merged commit d2d08c8 into django:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hramezani @felixxm