Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased test coverage of django.utils.datastructures to 100%. #13494

Merged
merged 4 commits into from
Oct 30, 2020
Merged

Increased test coverage of django.utils.datastructures to 100%. #13494

merged 4 commits into from
Oct 30, 2020

Commits on Oct 30, 2020

  1. Increased test coverage for django.utils.datastructures.OrderedSet. 

    Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
    @atombrella @ngnpope @felixxm
    2 people authored and felixxm committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    825f847 View commit details
    Browse the repository at this point in the history

  2. Increased test coverage for django.utils.datastructures.MultiValueDict. 

    Co-authored-by: Mads Jensen <mje@inducks.org>
    @ngnpope @atombrella @felixxm
    2 people authored and felixxm committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    c3d9b8b View commit details
    Browse the repository at this point in the history

  3. Removed unused custom exception support for ImmutableList. 

    If the warning provided was an instance of Exception, then it would be
used as-is. In practice this is untested, unused and ImmutableList is
an undocumented internal datastructure.
    @ngnpope @felixxm
    ngnpope authored and felixxm committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    1a8ad8a View commit details
    Browse the repository at this point in the history

  4. Updated MultiValueDict.update() to mirror dict.update() behavior. 

    Changes in behavior include:

- Accepting iteration over empty sequences, updating nothing.
- Accepting iterable of 2-tuples providing key-value pairs.
- Failing with the same or comparable exceptions for invalid input.

Notably this replaces the previous attempt to catch TypeError which was
unreachable as the call to .items() resulted in AttributeError on
non-dict objects.
    @ngnpope @felixxm
    ngnpope authored and felixxm committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    966b5b4 View commit details
    Browse the repository at this point in the history