Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #32069 -- Admin form layout broken at narrower browser widths #13514

Closed
wants to merge 5 commits into from
Closed

Fixed #32069 -- Admin form layout broken at narrower browser widths #13514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f48096
Fixed #32069 - Admin form layout broken at narrower browser widths in…
kilrogg Oct 8, 2020
781d3d7
Revert "Fixed #32069 - Admin form layout broken at narrower browser w…
kilrogg Oct 11, 2020
875d092
Fixed #32069 - Admin form layout broken at narrower browser widths in…
kilrogg Oct 11, 2020
30f9fa7
Fixed #32069 - Admin form layout broken at narrower browser widths in…
kilrogg Oct 8, 2020
1044cf1
Merge remote-tracking branch 'origin/master'
kilrogg Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion django/contrib/admin/static/admin/css/nav_sidebar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
max-width: calc(100% - 299px);
}

@media (max-width: 767px) {
@media (max-width: 847px) {
#nav-sidebar, #toggle-nav-sidebar {
display: none;
}
Expand Down
9 changes: 7 additions & 2 deletions django/contrib/admin/static/admin/css/responsive.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ input[type="submit"], button {

/* Mobile */

@media (max-width: 767px) {
@media (max-width: 847px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the breakpoints is out-of-scope for the is ticket. It would need consideration as a (breaking?) change in a separate ticket.

TBH I don't see the need: At 847px Just close the sidebar seems a reasonable policy testing now.

/* Layout */

#header, #content, #footer {
Expand Down Expand Up @@ -557,7 +557,12 @@ input[type="submit"], button {
.aligned .form-row,
.aligned .form-row > div {
display: flex;
max-width: 100vw;
flex-direction: column;
align-items: flex-start;
}

.aligned .form-row .checkbox-row {
display: block;
}

.aligned .form-row > div {
Expand Down