Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #20601 -- Allowed forcing format with thousand separators in floatformat filter. #13528

Merged
merged 1 commit into from Oct 13, 2020
Merged

Fixed #20601 -- Allowed forcing format with thousand separators in floatformat filter. #13528

merged 1 commit into from Oct 13, 2020

Conversation

jacobtylerwalls
Copy link
Member

@felixxm felixxm requested a review from claudep October 12, 2020 05:38
claudep
claudep requested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that is totally in line with my suggestion on the ticket.

django/template/defaultfilters.py Outdated Show resolved Hide resolved
django/template/defaultfilters.py Show resolved Hide resolved
tests/i18n/tests.py Outdated Show resolved Hide resolved
ngnpope
ngnpope suggested changes Oct 12, 2020
View reviewed changes
django/template/defaultfilters.py Outdated Show resolved Hide resolved
docs/ref/templates/builtins.txt Outdated Show resolved Hide resolved
@felixxm felixxm self-assigned this Oct 13, 2020
@felixxm felixxm changed the title Fixed #20601 -- Added suffix g to floatformat to force group separators. Fixed #20601 -- Allowed forcing format with thousand separators in floatformat filter. Oct 13, 2020
@jacobtylerwalls @felixxm
Fixed #20601 -- Allowed forcing format with thousand separators in fl…
ac6c426 
…oatformat filter.

Thanks Claude Paroz and Nick Pope for reviews.
felixxm
felixxm reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtylerwalls Thanks 👍

I pushed small edits.

docs/topics/i18n/formatting.txt Outdated Show resolved Hide resolved
tests/i18n/tests.py Outdated Show resolved Hide resolved
@felixxm
Copy link
Member

felixxm commented Oct 13, 2020

@claudep Do you want to take a look after updates?

@felixxm felixxm merged commit ac6c426 into django:master Oct 13, 2020
@jacobtylerwalls jacobtylerwalls deleted the floatformat_force_grouping branch October 13, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

@ngnpope ngnpope ngnpope requested changes

@claudep claudep claudep approved these changes

Assignees

@felixxm felixxm

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jacobtylerwalls @felixxm @claudep @ngnpope