Simplified MessageEncoder instantiation with default separators. #13679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
reviewed
Nov 13, 2020
|
On a related note: Does anyone know if we still support saving "non-json" messages? I feel like we could drop that |
felixxm
changed the title
felixxm
force-pushed
the
minimal_storage
branch
from
23a8dd2
to
d10425f
Compare
|
@apollo13 |
Weird I could have sworn that I saw something different in the tests scratches head |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only saves a few bytes, but it does not hurt us so it is probably
worth it. Since decoding is unaffected by this there are no backwards
compat issues.
I am sure @carltongibson will approve every saved byte :D