Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #32230 -- Made DataSource and LayerMapping support pathlib.Path. #13727

Merged
merged 2 commits into from Nov 28, 2020
Merged

Fixed #32230 -- Made DataSource and LayerMapping support pathlib.Path. #13727

merged 2 commits into from Nov 28, 2020

Conversation

hramezani
Copy link
Member

@felixxm
Copy link
Member

felixxm commented Nov 27, 2020

@hramezani Thanks for the patch 👍 We encourage triage by the community, so feel-free to accept the ticket if you think it's a viable and reasonable feature.

claudep
claudep approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ngnpope
Copy link
Member

ngnpope commented Nov 27, 2020

...accept the ticket if you think it's a viable and reasonable feature.

I've accepted, as I suppose it's reasonable... 😉

@hramezani
Copy link
Member Author

...accept the ticket if you think it's a viable and reasonable feature.

I've accepted, as I suppose it's reasonable...

Thanks @pope1ni 👍

@felixxm felixxm changed the title Fixed #32230 -- Added support for pathlib.Path to the django.contrib.gis.gdal.DataSource. Fixed #32230 -- Made django.contrib.gis.gdal.DataSource support pathlib.Path. Nov 28, 2020
@felixxm felixxm changed the title Fixed #32230 -- Made django.contrib.gis.gdal.DataSource support pathlib.Path. Fixed #32230 -- Made DataSource and LayerMapping support pathlib.Path. Nov 28, 2020
@felixxm
Copy link
Member

felixxm commented Nov 28, 2020

@hramezani Thanks 👍

I've noticed that LayerMapping doesn't support pathlib.Path either, so I fixed this in a separate commit 931c6e9 and opened PR #13729 with docs fix for Django 3.1. @claudep Can you take a look?

@claudep
Copy link
Member

claudep commented Nov 28, 2020

Even better, thanks a lot!

@felixxm felixxm merged commit 931c6e9 into django:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@hramezani @felixxm @ngnpope @claudep