Fixed #32235 -- Made ReadOnlyPasswordHashField disabled by default. #13741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Dec 2, 2020
There was a problem hiding this comment.
@timoludwig Thanks for this patch 👍 I left small comments, we should also add a short release note about changing the default value of ReadOnlyPasswordHashField.disabled in the "Backwards incompatible changes in 3.2 -> Miscellaneous".
timobrembeck
force-pushed
the
ticket_32235
branch
from
80a46cf
to
23ceb2c
Compare
|
@felixxm Thanks for your review! I have addressed your comments, let me know if there is anything I need to improve. |
felixxm
changed the title
|
@timoludwig Thanks 👍 Welcome aboard ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #32235
Set
disabled=Truein contrib.auth'sReadOnlyPasswordHashFieldwhich made the custombound_data()andhas_changed()methods obsolete. This also eliminated the need for aclean_password()method in the form using that field, e.g. theUserChangeForm.I'm not sure whether my test is reasonable - technically, there are other tests which fail if the methods are removed without setting the disabled flag. Is the disabled property a valid requirement here or just an implementation detail and what really matters is that the disabled-functionality is achieved (
has_changed = Falseandbound_data/cleaned_data = initial)?Thanks in advance for your feedback!