Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #32442 -- Used converters on returning fields from INSERT statements. #14007

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

adamchainz
Copy link
Sponsor Member

@adamchainz adamchainz commented Feb 13, 2021

Base automatically changed from master to main March 9, 2021 06:21
@felixxm felixxm changed the title Fixes #32442 -- Added DB converter execution on insert returning fields. Fixed #32442 -- Used converters on returning fields from INSERT statements. Apr 7, 2021
tests/custom_pk/tests.py Outdated Show resolved Hide resolved
@felixxm felixxm force-pushed the ticket_32442_database_converters branch from 445ddbe to c722a6a Compare April 7, 2021 09:34
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamchainz Thanks for this patch 👍

I pushed small edits and simplified "compiler" changes a bit.

tests/custom_pk/fields.py Outdated Show resolved Hide resolved
@felixxm felixxm force-pushed the ticket_32442_database_converters branch from c722a6a to 8381946 Compare April 7, 2021 09:35
@felixxm felixxm force-pushed the ticket_32442_database_converters branch from 8381946 to d9de741 Compare April 7, 2021 15:10
@adamchainz
Copy link
Sponsor Member Author

LGTM

@felixxm felixxm merged commit d9de741 into django:main Apr 7, 2021
@adamchainz adamchainz deleted the ticket_32442_database_converters branch April 7, 2021 16:08
@adamchainz
Copy link
Sponsor Member Author

Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants