Fixed #27854 -- Added system check for nonexistent directories in STATICFILES_DIRS setting. #14056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
force-pushed
the
ticket-27854
branch
2 times, most recently
from
84aab66
to
c9c8edd
Compare
jacobtylerwalls
force-pushed
the
ticket-27854
branch
2 times, most recently
from
5c6a7ee
to
37debdd
Compare
felixxm
reviewed
Mar 3, 2021
There was a problem hiding this comment.
@jacobtylerwalls Thanks for updates 👍
I reorganized commits, added a small cleanup with using CollectionTestCase in FindersCheckTests tests, and pushed minor edits.
| Warning( | ||
| 'The directory /fake/path in the STATICFILES_DIRS setting does not exist.', | ||
| id='staticfiles.W004', | ||
| ), |
There was a problem hiding this comment.
We shouldn't mix a new check with existing tests. I would move it to a separate method.
Comment on lines
54
to
59
| @override_settings(STATICFILES_DIRS=container_for_tempdir) | ||
| def test_no_errors_with_provided_directory(self): | ||
| with tempfile.TemporaryDirectory() as tmpdirname: | ||
| self.container_for_tempdir.append(tmpdirname) | ||
| self.assertEqual(check_finders(None), []) | ||
|
|
There was a problem hiding this comment.
This is redundant with test_no_errors_with_test_settings because CollectionTestCase uses existing directories.
felixxm
changed the title
carltongibson
approved these changes
Mar 3, 2021
felixxm
reviewed
Mar 3, 2021
|
|
||
| class FindersCheckTests(SimpleTestCase): | ||
|
|
||
| class FindersCheckTests(CollectionTestCase): |
There was a problem hiding this comment.
Using CollectionTestCase gives us existing directories in "static" settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket-27854