Refs #32508 -- Raised ValueError instead of using "assert" in lazy(). #14114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Mar 11, 2021
There was a problem hiding this comment.
@hramezani Thanks for this patch 👍 , however I would leave most of these asserts.
hramezani
force-pushed
the
ref_ticket_32508_utils
branch
from
742d15b
to
4bb316e
Compare
felixxm
reviewed
Mar 15, 2021
| from django.test import SimpleTestCase | ||
| from django.utils import regex_helper | ||
|
|
||
|
|
||
| class NormalizeTests(unittest.TestCase): | ||
| class NormalizeTests(SimpleTestCase): |
There was a problem hiding this comment.
This is not required. I'll drop the last commit.
felixxm
force-pushed
the
ref_ticket_32508_utils
branch
from
4bb316e
to
775b796
Compare
felixxm
reviewed
Mar 15, 2021
felixxm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/32508