Refs #32508 -- Raised Type/ValueError instead of using "assert" in django.core.

[abbasidaniyal]

No description provided.

[felixxm]

@abbasidaniyal Thanks 👍 Can you also audit other uses of assert in django/core?:

• django/core/mail/message.py: assert content is None
• django/core/mail/message.py: assert mimetype is None
• django/core/mail/message.py: assert content is not None
• django/core/mail/message.py: assert content is not None
• django/core/mail/message.py: assert mimetype is not None
• django/core/files/storage.py: assert name, "The name argument is not allowed to be empty."

and add tests for uncovered error messages.

[abbasidaniyal]

@abbasidaniyal Thanks 👍 Can you also audit other uses of assert in django/core?:

• django/core/mail/message.py: assert content is None
• django/core/mail/message.py: assert mimetype is None
• django/core/mail/message.py: assert content is not None
• django/core/mail/message.py: assert content is not None
• django/core/mail/message.py: assert mimetype is not None
• django/core/files/storage.py: assert name, "The name argument is not allowed to be empty."

and add tests for uncovered error messages.

Sure! I was thinking of adding the tests too. Didn't find any previously hence skipped it.
On it now!

[abbasidaniyal]

@felixxm It seems as if CheckMessage and it's sub classes (Debug, Info etc) do not have any tests.
I was planning on creating a new file unders tests/check_framework named test_messages.py. Let me know if that's alright.

In the meantime, I'm working on the other instances of assert in django.core.

[felixxm]

@felixxm It seems as if CheckMessage and it's sub classes (Debug, Info etc) do not have any tests.

You can add a test to the check_framework.tests.MessageTests.

[felixxm]

@abbasidaniyal Thanks 👍

I pushed edits, simplified tests, and added small elease notes.