Fixed #32582 -- Removed unnecessary dot in names of cloned test databases on SQLite. #14169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girishsontakke
changed the title
|
Hello @girishsontakke! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
felixxm
reviewed
Mar 23, 2021
There was a problem hiding this comment.
@girishsontakke Thanks for this patch 👍
Please add tests to the tests/backends/sqlite/test_creation.py.
|
Thank you @felixxm for your review and suggestion. |
felixxm
reviewed
Mar 24, 2021
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
felixxm
changed the title
|
@girishsontakke Welcome aboard ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed https://code.djangoproject.com/ticket/32582.
I am not sure in which section of the project I would have to write a test for this patch but if someone guides me then I will definitely write a test for this patch.