Fixed #32671 -- Fix CSS var() + relative url() issue in Safari. #14294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a regression test is difficult to add here, I would add a comment in the CSS file linking to this issue, otherwise someone else could come later and propose a patch to regroup the "doubled" background lines. |
|
@claudep good suggestion, I have added that. |
carltongibson
changed the title
|
Closing as per ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Safari where using the var() property alongside a url() that contains a relative path, the relative path will break. The bug also existed in Chrome (https://bugs.chromium.org/p/chromium/issues/detail?id=618165), which has been fixed. However the Safari bug still exists as of Mac OS 11.2.3.
Expected Output
Actual Output
As you can see from the console, the URLs end up being relative to the current page URL, not the CSS file URL in which they are loaded.
This bug was introduced in 0a80223
Related Trac:
https://code.djangoproject.com/ticket/32671