Refs #24121 -- Added __repr__() to AdminForm, BlockContext, BlockTranslateNode, and IncludeNode. #14504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
force-pushed
the
Refs#24121--Added__repr__()toIncludeNode,BlockContext,AdminForm,InlineAdminFormSet,andBlockTranslateNode
branch
from
346e0bb
to
3d17968
Compare
felixxm
reviewed
Jun 10, 2021
There was a problem hiding this comment.
@saeedblanchette Thanks 👍
I moved tests to the correct files and pushed small edits.
felixxm
changed the title
…slateNode, and IncludeNode.
felixxm
force-pushed
the
Refs#24121--Added__repr__()toIncludeNode,BlockContext,AdminForm,InlineAdminFormSet,andBlockTranslateNode
branch
from
3d17968
to
66ed03e
Compare
saeedblanchette
deleted the
Refs#24121--Added__repr__()toIncludeNode,BlockContext,AdminForm,InlineAdminFormSet,andBlockTranslateNode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I see that
InlineAdminFormSetinherits fromAdminFormso I think we don't need to add to it__repr__Also, I'm not sure where I should put those tests.
Thank you for reviewing