Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #32941 -- Removed get_format_modules()'s unused reverse argument. #14659

Merged
merged 1 commit into from Jul 19, 2021
Merged

Fixed #32941 -- Removed get_format_modules()'s unused reverse argument. #14659

merged 1 commit into from Jul 19, 2021

Conversation

kezabelle
Copy link
Contributor

Ticket 32941. Opened to get the full CI to run and demonstrate it should at least be feasible to remove.

@kezabelle kezabelle marked this pull request as ready for review July 18, 2021 13:46
ngnpope
ngnpope suggested changes Jul 18, 2021
View reviewed changes
django/utils/formats.py Outdated Show resolved Hide resolved
tests/i18n/tests.py Outdated Show resolved Hide resolved
cjerdonek
cjerdonek reviewed Jul 18, 2021
View reviewed changes
tests/i18n/tests.py Outdated Show resolved Hide resolved
@ngnpope
Copy link
Member

ngnpope commented Jul 18, 2021

Just confirming that the reverse argument has been unused since 0d8b523.

@felixxm felixxm changed the title Fixed #32941 - Removed unused reverse parameter of get_format_modules Fixed #32941 - Removed get_format_modules()'s unused reverse argument. Jul 19, 2021
@kezabelle
Copy link
Contributor Author

Thanks both for checking more thoroughly :) Updated as per both.
Apologies, CI bot, but you are invoked again as I force push my way to correctness.

@felixxm
Copy link
Member

felixxm commented Jul 19, 2021

@kezabelle Thanks 👍

@felixxm felixxm changed the title Fixed #32941 - Removed get_format_modules()'s unused reverse argument. Fixed #32941 -- Removed get_format_modules()'s unused reverse argument. Jul 19, 2021
@felixxm felixxm merged commit 59942a6 into django:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjerdonek cjerdonek cjerdonek left review comments

@ngnpope ngnpope ngnpope requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kezabelle @ngnpope @felixxm @cjerdonek