Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #32962 -- Consolidated string concatenations in BaseDatabaseSchemaEditor.column_sql(). #14701

Merged
merged 2 commits into from Jul 27, 2021
Merged

Fixed #32962 -- Consolidated string concatenations in BaseDatabaseSchemaEditor.column_sql(). #14701

merged 2 commits into from Jul 27, 2021

Conversation

cjerdonek
Copy link
Contributor

felixxm
felixxm reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjerdonek Thanks 👍

django/db/backends/base/schema.py Outdated Show resolved Hide resolved
django/db/backends/base/schema.py Outdated Show resolved Hide resolved
@cjerdonek cjerdonek force-pushed the ticket-32962-column-sql-string-concatenations branch from 400eac2 to ad59005 Compare July 27, 2021 14:25
@cjerdonek
Copy link
Contributor Author

Thanks, @felixxm! I also went ahead and cleaned the comments and docstring in the method.

@felixxm felixxm force-pushed the ticket-32962-column-sql-string-concatenations branch from 70721d4 to fe074c9 Compare July 27, 2021 18:11
@felixxm
Copy link
Member

felixxm commented Jul 27, 2021

@cjerdonek Thanks 👍 Looks great 🥇

@felixxm felixxm merged commit fe074c9 into django:main Jul 27, 2021
@cjerdonek cjerdonek deleted the ticket-32962-column-sql-string-concatenations branch July 27, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cjerdonek @felixxm