Fixed #32959 -- Moved tests URLs to validators.tests. #14705
Conversation
|
Hello @chrishna1! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
There was a problem hiding this comment.
I would do this in two commits, IMO, using the first commit to show that the test data in the module matches the test data in the file. This can be done with an assert after each url is read. The second commit can then remove the text files. The two commits would be squashed prior to merging.
chrishna1
force-pushed
the
main
branch
2 times, most recently
from
551b15b
to
de10213
Compare
|
Hi @cjerdonek, thanks for your input. I've made changes according to that. |
felixxm
changed the title
|
@chrishna1 Thanks 👍 Welcome aboard ⛵ I squashed commits and pushed minor edits. |
No description provided.