Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused and unnecessary words from docs/spelling_wordlist. #14712

Merged
merged 2 commits into from Jul 30, 2021

Conversation

smithdc1
Copy link
Member

Removed words contained within the Enchant dictionary

Maybe a bit speculative. There are many words which have now made it into the en_US dictionary and are no longer required in Django's custom wordlist. This passes locally for me atleast, but I'm slightly unsure if folk will get different dictionaries from the underlying sources?

@felixxm
Copy link
Member

felixxm commented Jul 29, 2021

@smithdc1 Thanks 👍 however we need to be consistent with djangoproject.com which runs on Ubuntu 18.04 (see failures in #14714). We should change GitHub actions to use Ubuntu 18.04 in the docs check (see #14715).

@ngnpope
Copy link
Member

ngnpope commented Jul 29, 2021

Thanks @smithdc1. I agree with @felixxm on this - we should be developing for production and targeting the same versions as closely as possible.

Please do revisit this when djangoproject.com uses 20.04. I really appreciate these efforts that go into unglamorous, background maintenance. 🙂

@ngnpope ngnpope closed this Jul 29, 2021
@felixxm
Copy link
Member

felixxm commented Jul 29, 2021

@smithdc1 You can rebase and check again with #14715. Maybe some of these words can be removed, but not Django.

@felixxm felixxm reopened this Jul 29, 2021
@felixxm
Copy link
Member

felixxm commented Jul 29, 2021

Only few words should be reverted according to logs:

  • Django
  • iOS
  • covariance
  • viewable
  • interoperability
  • unmaintained

Removed words contained within the Enchant dictionary
@ngnpope
Copy link
Member

ngnpope commented Jul 29, 2021

Sorry for closing prematurely, indeed there is some clean up that can be done now.

It looks like you've removed some names that are referenced in the old release notes which will need to remain.

@smithdc1
Copy link
Member Author

I really appreciate these efforts..

Thank you! For me it's all about learning, writing a few short scripts today to get the relavent info out of the logs was an enjoyable challenge for me.

It looks like you've removed some names

Yes, I guess locally it passes for me as it picks the names up from the contributors, but I am unsure why that doesn't work here. Anyway there's only a handful so I've added them back.

Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smithdc1.

@felixxm felixxm changed the title Updated spelling_wordlist Removed unused and unnecessary words from docs/spelling_wordlist. Jul 30, 2021
@felixxm felixxm merged commit 40d3cec into django:main Jul 30, 2021
@smithdc1 smithdc1 deleted the spelling branch August 21, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants