Fixed #33008 -- Fixed prefetch_related() for deleted GenericForeignKeys. #14762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
changed the title
felixxm
reviewed
Oct 14, 2021
There was a problem hiding this comment.
@martinsvoboda Thanks for this patch 👍 Welcome aboard ⛵
I squashed commits and switched AuditLog to Post in tests.
felixxm
force-pushed
the
fix-deleted-obj-gfk
branch
2 times, most recently
from
2e0935c
to
84cfa2a
Compare
Thanks Simon Charette for the implementation idea.
felixxm
force-pushed
the
fix-deleted-obj-gfk
branch
from
84cfa2a
to
cc4cb95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for #33008 issue. prefetch_related don't set content_type_id and object_id to None, if GFK object is not found.