Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #33043 -- Made method_decorator() preserve wrapper assignments. #14787

Merged
merged 1 commit into from Oct 20, 2021
Merged

Fixed #33043 -- Made method_decorator() preserve wrapper assignments. #14787

merged 1 commit into from Oct 20, 2021

Conversation

vinayinvicible
Copy link
Contributor

@vinayinvicible vinayinvicible commented Aug 23, 2021 •
edited

@vinayinvicible vinayinvicible changed the title Fixed method_decorator() not setting wrapper assignments Fixed #33043 -- method_decorator() now preserves wrapper assignments Aug 23, 2021
@cjerdonek cjerdonek self-requested a review August 24, 2021 11:33
@felixxm
Copy link
Member

felixxm commented Oct 19, 2021

@tim-mccurrach @ngnpope Can you take a look? I remember your discussion about update_wrapper() in the:

tim-mccurrach
tim-mccurrach approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@tim-mccurrach tim-mccurrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me.

Having read through all of method_decorator it looks like it's never going to handle decorators that do much introspection very well, but that's a conversation for another day.

@ngnpope unless you have any issues I'll move this ticket to RFC

ngnpope
ngnpope approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine.

@felixxm felixxm self-assigned this Oct 20, 2021
@felixxm
Copy link
Member

felixxm commented Oct 20, 2021

Thanks both for reviews 🌟

@felixxm
Copy link
Member

felixxm commented Oct 20, 2021

@vinayinvicible Thanks for the patch 👍

I pushed small edits to tests.

@felixxm felixxm changed the title Fixed #33043 -- method_decorator() now preserves wrapper assignments Fixed #33043 -- Made method_decorator() preserve wrapper assignments. Oct 20, 2021
@felixxm felixxm merged commit 8806e88 into django:main Oct 20, 2021
@vinayinvicible vinayinvicible deleted the ticket_33043 branch October 21, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngnpope ngnpope ngnpope approved these changes

@tim-mccurrach tim-mccurrach tim-mccurrach approved these changes

@cjerdonek cjerdonek Awaiting requested review from cjerdonek

Assignees

@felixxm felixxm

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@vinayinvicible @felixxm @ngnpope @tim-mccurrach