Fixed #16063 -- Adjusted admin changelist searches spanning multi-valued relationships.

[jacobtylerwalls]

ticket-16063

mailing list thread

Reduces the likelihood of admin searches issuing queries with excessive joins.

[jacobtylerwalls]

After Adam's response on mailing list that we should be sure to add tips for users upgrading, maybe we could document the new behavior in get_search_results() and add a code snippet for achieving the old way of filtering. And then point to this from release notes.

EDIT: I'm less sanguine on this after trying to write an example code block. Most of get_search_results would have to be copied, I think. Perhaps we should go with creating and deprecating an option.

[felixxm]

@jacobtylerwalls Please rebase after 948d6d8.

[felixxm]

@jacobtylerwalls Thanks 👍 Personally, I'm in favor, just wondering how to increase visibility of this change. I'm pretty sure that affected user will not notice it until it's too late 😞 . A separate section in the release notes and extra annotation in ModelAdmin.search_fields docs should be a good start.

[carltongibson]

Hey @jacobtylerwalls — thanks for this!

I just had a comment on the docs changes… Let me know your thoughts.
(Once we're happy, I'd apply similar throughout; I think for the 4.1.txt block, the final the old way caused too many joins is OK.)

[carltongibson]

@jacobtylerwalls I quite like that, thank you. Let's see what @felixxm says.
🥇

[felixxm]

Thanks both 🚀