Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #33246 -- Made squashmigrations raise CommandError when squashed_name already exists. #15038

Merged
merged 3 commits into from Nov 2, 2021

Conversation

andrewdotn
Copy link
Contributor

No description provided.

@github-actions
Copy link

Hello @andrewdotn! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@andrewdotn andrewdotn changed the title Fix #33246 --squashed-name can overwrite migration Fixed #33246 squashed-name can overwrite migration Oct 30, 2021
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewdotn Thanks for this patch 👍

tests/migrations/test_commands.py Outdated Show resolved Hide resolved
django/core/management/commands/squashmigrations.py Outdated Show resolved Hide resolved
@andrewdotn
Copy link
Contributor Author

Patch updated.

@felixxm
Copy link
Member

felixxm commented Nov 2, 2021

@andrewdotn Thanks for updates 👍 I would like to push small edits. Can you check "Allow edits by maintainers"?
image

@felixxm felixxm changed the title Fixed #33246 squashed-name can overwrite migration Fixed #33246 -- Made squashmigrations raise CommandError when squashed_name already exists. Nov 2, 2021
django/core/management/commands/squashmigrations.py Outdated Show resolved Hide resolved
django/core/management/commands/squashmigrations.py Outdated Show resolved Hide resolved
tests/migrations/test_commands.py Outdated Show resolved Hide resolved
tests/migrations/test_commands.py Outdated Show resolved Hide resolved
tests/migrations/test_commands.py Outdated Show resolved Hide resolved
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@andrewdotn
Copy link
Contributor Author

I’ve checked the “Allow edits by maintainers” box.

@felixxm
Copy link
Member

felixxm commented Nov 2, 2021

@andrewdotn Thanks 👍 Welcome aboard ⛵

@felixxm felixxm merged commit 9e6d631 into django:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants