Fixed #33252 -- Made cache middleware thread safe. #15044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurisilvio
force-pushed
the
cache-middleware-thread-safe
branch
2 times, most recently
from
6a19f03
to
7f0591a
Compare
iurisilvio
commented
Nov 1, 2021
|
I added a second commit removing the setter that I added in the first one and changing other tests to make it pass. I don't know if I'm allowed to do that. The setter I added first was to make other tests pass, but removing this set don't break anything. |
iurisilvio
force-pushed
the
cache-middleware-thread-safe
branch
2 times, most recently
from
cae22db
to
2767657
Compare
felixxm
reviewed
Nov 2, 2021
felixxm
reviewed
Nov 2, 2021
iurisilvio
force-pushed
the
cache-middleware-thread-safe
branch
from
c1477c2
to
2c2557c
Compare
…rite_unpicklable_object()
|
@iurisilvio Thanks 👍 |
felixxm
force-pushed
the
cache-middleware-thread-safe
branch
from
2c2557c
to
b0c4e15
Compare
pauloxnet
reviewed
Nov 3, 2021
felixxm
force-pushed
the
cache-middleware-thread-safe
branch
from
b0c4e15
to
3ff7b15
Compare
pauloxnet
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
caches[key]response is not thread safe. It must be called insidethe correct thread to return a new object.
https://docs.djangoproject.com/en/3.2/topics/cache/#accessing-the-cache