Fixed #33257 -- Fixed Case() and ExpressionWrapper() with decimal values on SQLite. #15062
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
reviewed
Nov 4, 2021
matthijskooijman
force-pushed
the
decimalfield-comparisons
branch
from
163e3b7
to
ba0d214
Compare
felixxm
reviewed
Nov 8, 2021
There was a problem hiding this comment.
@matthijskooijman Thanks 👍
I added assertSequenceEqual() to tests.
felixxm
force-pushed
the
decimalfield-comparisons
branch
from
ba0d214
to
a625edf
Compare
felixxm
changed the title
|
Looks good, thanks! |
felixxm
force-pushed
the
decimalfield-comparisons
branch
from
a625edf
to
1a50238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ExpressionWrapper was used to wrap a non-decimal Value with
output_field=DecimalField, it would not be converted to the right type
(NUMERIC) on SQLite, causing comparisons with proper decimals to fail.
Adding SQLiteNumericMixin ensures that the proper conversion is done
when needed.
In a slightly different way, when a Case/When is used to wrap a
Decimal/DecimalField value (literal or model field), it seems to be
converted to a non-decimal type (by SQLite it seems), also causing
comparisons to fail. Adding SQLiteNumericMixin also helps here.